Mark functions nve0_gpio_intr(), nve0_gpio_intr_enable(), nve0_gpio_intr_disable(), nve0_gpio_fini() and nve0_gpio_init() as static in drm/nouveau/core/subdev/gpio/nve0.c because they are not used outside this file. Remove unused function nve0_gpio_dtor() from file drm/nouveau/core/subdev/gpio/nve0.c. This eliminates the following warnings in drm/nouveau/core/subdev/gpio/nve0.c: drivers/gpu/drm/nouveau/core/subdev/gpio/nve0.c:32:1: warning: no previous prototype for ‘nve0_gpio_intr’ [-Wmissing-prototypes] drivers/gpu/drm/nouveau/core/subdev/gpio/nve0.c:51:1: warning: no previous prototype for ‘nve0_gpio_intr_enable’ [-Wmissing-prototypes] drivers/gpu/drm/nouveau/core/subdev/gpio/nve0.c:60:1: warning: no previous prototype for ‘nve0_gpio_intr_disable’ [-Wmissing-prototypes] drivers/gpu/drm/nouveau/core/subdev/gpio/nve0.c:69:1: warning: no previous prototype for ‘nve0_gpio_fini’ [-Wmissing-prototypes] drivers/gpu/drm/nouveau/core/subdev/gpio/nve0.c:78:1: warning: no previous prototype for ‘nve0_gpio_init’ [-Wmissing-prototypes] drivers/gpu/drm/nouveau/core/subdev/gpio/nve0.c:93:1: warning: no previous prototype for ‘nve0_gpio_dtor’ [-Wmissing-prototypes] Signed-off-by: Rashika Kheria <rashika.kheria@xxxxxxxxx> Reviewed-by: Josh Triplett <josh@xxxxxxxxxxxxxxxx> --- drivers/gpu/drm/nouveau/core/subdev/gpio/nve0.c | 17 +++++------------ 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/nouveau/core/subdev/gpio/nve0.c b/drivers/gpu/drm/nouveau/core/subdev/gpio/nve0.c index 16b8c5b..428374a 100644 --- a/drivers/gpu/drm/nouveau/core/subdev/gpio/nve0.c +++ b/drivers/gpu/drm/nouveau/core/subdev/gpio/nve0.c @@ -28,7 +28,7 @@ struct nve0_gpio_priv { struct nouveau_gpio base; }; -void +static void nve0_gpio_intr(struct nouveau_subdev *subdev) { struct nve0_gpio_priv *priv = (void *)subdev; @@ -47,7 +47,7 @@ nve0_gpio_intr(struct nouveau_subdev *subdev) nv_wr32(priv, 0xdc88, intr1); } -void +static void nve0_gpio_intr_enable(struct nouveau_event *event, int line) { const u32 addr = line < 16 ? 0xdc00 : 0xdc80; @@ -56,7 +56,7 @@ nve0_gpio_intr_enable(struct nouveau_event *event, int line) nv_mask(event->priv, addr + 0x00, mask, mask); } -void +static void nve0_gpio_intr_disable(struct nouveau_event *event, int line) { const u32 addr = line < 16 ? 0xdc00 : 0xdc80; @@ -65,7 +65,7 @@ nve0_gpio_intr_disable(struct nouveau_event *event, int line) nv_mask(event->priv, addr + 0x00, mask, 0x00000000); } -int +static int nve0_gpio_fini(struct nouveau_object *object, bool suspend) { struct nve0_gpio_priv *priv = (void *)object; @@ -74,7 +74,7 @@ nve0_gpio_fini(struct nouveau_object *object, bool suspend) return nouveau_gpio_fini(&priv->base, suspend); } -int +static int nve0_gpio_init(struct nouveau_object *object) { struct nve0_gpio_priv *priv = (void *)object; @@ -89,13 +89,6 @@ nve0_gpio_init(struct nouveau_object *object) return 0; } -void -nve0_gpio_dtor(struct nouveau_object *object) -{ - struct nve0_gpio_priv *priv = (void *)object; - nouveau_gpio_destroy(&priv->base); -} - static int nve0_gpio_ctor(struct nouveau_object *parent, struct nouveau_object *engine, struct nouveau_oclass *oclass, void *data, u32 size, -- 1.7.9.5 _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel