On Sun, Nov 10, 2013 at 8:32 PM, Tomasz Figa <tomasz.figa@xxxxxxxxx> wrote: > On Tuesday 29 of October 2013 12:13:07 Sean Paul wrote: >> This patch moves the code from video/ to drm/ > > Again, rationale should be mentioned in patch description. > >> Signed-off-by: Sean Paul <seanpaul@xxxxxxxxxxxx> >> --- >> >> Changes in v2: None >> Changes in v3: None >> >> drivers/gpu/drm/exynos/Kconfig | 7 + >> drivers/gpu/drm/exynos/Makefile | 1 + >> drivers/gpu/drm/exynos/exynos_dp_core.c | 1213 ++++++++++++++++++++++++++++++ >> drivers/gpu/drm/exynos/exynos_dp_core.h | 210 ++++++ >> drivers/gpu/drm/exynos/exynos_dp_reg.c | 1245 +++++++++++++++++++++++++++++++ >> drivers/gpu/drm/exynos/exynos_dp_reg.h | 366 +++++++++ >> drivers/video/exynos/Kconfig | 7 - >> drivers/video/exynos/Makefile | 1 - >> drivers/video/exynos/exynos_dp_core.c | 1213 ------------------------------ >> drivers/video/exynos/exynos_dp_core.h | 210 ------ >> drivers/video/exynos/exynos_dp_reg.c | 1245 ------------------------------- >> drivers/video/exynos/exynos_dp_reg.h | 366 --------- >> 12 files changed, 3042 insertions(+), 3042 deletions(-) >> create mode 100644 drivers/gpu/drm/exynos/exynos_dp_core.c >> create mode 100644 drivers/gpu/drm/exynos/exynos_dp_core.h >> create mode 100644 drivers/gpu/drm/exynos/exynos_dp_reg.c >> create mode 100644 drivers/gpu/drm/exynos/exynos_dp_reg.h >> delete mode 100644 drivers/video/exynos/exynos_dp_core.c >> delete mode 100644 drivers/video/exynos/exynos_dp_core.h >> delete mode 100644 drivers/video/exynos/exynos_dp_reg.c >> delete mode 100644 drivers/video/exynos/exynos_dp_reg.h >> >> diff --git a/drivers/gpu/drm/exynos/Kconfig b/drivers/gpu/drm/exynos/Kconfig >> index 45b6ef5..3ace74f 100644 >> --- a/drivers/gpu/drm/exynos/Kconfig >> +++ b/drivers/gpu/drm/exynos/Kconfig >> @@ -30,6 +30,13 @@ config DRM_EXYNOS_FIMD >> help >> Choose this option if you want to use Exynos FIMD for DRM. >> >> +config DRM_EXYNOS_DP > > I would keep the symbol name as it was, so configs used by people remain > valid. > I don't really want to do that. All of the other configs are named DRM_EXYNOS_BLAH, DP should follow this convention. There are a few ways around this: 1) Make DRM_EXYNOS_DP default to on if DRM_EXYNOS is selected 2) Make a shadow EXYNOS_DP config that selects DRM_EXYNOS_DP Either of those work for you? > Also, don't you need some kind of dependency on DRM_EXYNOS? > Yep, will do. Sean > Otherwise this patch is fine. > > Best regards, > Tomasz > _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
