Re: [PATCH 2/2] drm/i915: Return a drm_mode_status enum in the mode_valid vfuncs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Nov 28, 2013 at 04:49:52PM +0100, Daniel Vetter wrote:
> On Thu, Nov 28, 2013 at 03:29:18PM +0000, Damien Lespiau wrote:
> > We had some mode_valid() vfuncs returning an int, others the enum. Let's
> > use the latter everywhere.
> > 
> > Signed-off-by: Damien Lespiau <damien.lespiau@xxxxxxxxx>
> 
> Yeah, makes sense. Queued for -next, thanks for the patch.
> 
> -Daniel
> > ---
> >  drivers/gpu/drm/i915/intel_crt.c  | 5 +++--
> >  drivers/gpu/drm/i915/intel_dp.c   | 2 +-
> >  drivers/gpu/drm/i915/intel_dsi.c  | 5 +++--
> >  drivers/gpu/drm/i915/intel_dvo.c  | 5 +++--
> >  drivers/gpu/drm/i915/intel_hdmi.c | 5 +++--
> >  drivers/gpu/drm/i915/intel_lvds.c | 5 +++--
> >  drivers/gpu/drm/i915/intel_sdvo.c | 5 +++--
> >  7 files changed, 19 insertions(+), 13 deletions(-)

Shouldn't you be updating all other drivers as well? GCC doesn't seem to
complain about it, but it's still an inconsistency.

Thierry

Attachment: pgpB1ovDf2CP8.pgp
Description: PGP signature

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux