2013-11-22 17:35, Arthur Schwalbenberg: > > From 340fa01dfe8f699e27ece111996ea088bca6b5c4 Mon Sep 17 00:00:00 2001 > From: Arthur Schwalbenberg <aschwal@xxxxxxxxxxx> > Date: Thu, 21 Nov 2013 19:42:44 -0500 > Subject: [PATCH] Staging: Fixed compilar warnings and coding style > issues in i915_debugfs.c > MIME-Version: 1.0 > Content-Type: text/plain; charset=UTF-8 > Content-Transfer-Encoding: 8bit > > This is a patch fixing both a compilar warning: > ‘val’ may be used uninitialized in this function > and various coding style issues which include line length > warnings and a few errors as defined by 'checkpatch.pl' tool > > Signed-off-by: Arthur Schwalbenberg <aschwal@xxxxxxxxxxx> Hi, When you break 80+ lines into two lines, you should also indent the newly created line so that it shows that it is a part of something. I as well don't think it is worth splitting lines that are 84 characters long into two lines, that just doesn't make sense. Also, your patch seems (atleast to me) a 'bit' whitespace damaged. -- Regards, Levente Kurusa _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
