On Wed, Nov 13, 2013 at 08:53:18AM +0100, Eric Bénard wrote: > Hi Russell, > > Le Tue, 12 Nov 2013 17:04:55 +0000, > Russell King - ARM Linux <linux@xxxxxxxxxxxxxxxx> a écrit : > > On Tue, Nov 12, 2013 at 05:49:18PM +0100, Denis Carikli wrote: > > > diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c > > > index fc2adb6..586c12f 100644 > > > --- a/drivers/gpu/drm/drm_modes.c > > > +++ b/drivers/gpu/drm/drm_modes.c > > > @@ -537,6 +537,15 @@ int drm_display_mode_from_videomode(const struct videomode *vm, > > > dmode->flags |= DRM_MODE_FLAG_DBLSCAN; > > > if (vm->flags & DISPLAY_FLAGS_DOUBLECLK) > > > dmode->flags |= DRM_MODE_FLAG_DBLCLK; > > > + if (vm->flags & DISPLAY_FLAGS_DE_LOW) > > > + dmode->flags |= DRM_MODE_FLAG_DE_LOW; > > > + if (vm->flags & DISPLAY_FLAGS_DE_HIGH) > > > + dmode->flags |= DRM_MODE_FLAG_DE_HIGH; > > > + if (vm->flags & DISPLAY_FLAGS_PIXDATA_POSEDGE) > > > + dmode->flags |= DRM_MODE_FLAG_PIXDATA_POSEDGE; > > > + if (vm->flags & DISPLAY_FLAGS_PIXDATA_NEGEDGE) > > > + dmode->flags |= DRM_MODE_FLAG_PIXDATA_NEGEDGE; > > > + > > > > I'm still not convinced that these should be exposed in *any* way to > > userspace - I'm with Ville Syrjälä on this point. > > > > Yes, you've moved their definition out of a uapi header file, but > > they're still leaking out of kernel space via calls (and with Xorg, > > they'll leak into the DisplayMode structures within the X server.) > > > > Now, here's the thing... The polarity of the display enable signal. > > That's a property of the connected device right? It doesn't change > > with respect to the displayed mode unlike the hsync/vsync signals. > > If that's true, it should not be here. > > > > Same goes for the pixel clock edge. If it's a property of the > > connected device and doesn't have a dependence on the displayed > > mode, then it should not be in the DRM mode structure. > > What would be the right way to configure these settings without > exposing them to userspace ? > > As explained in my answer to Fabio, these settings are currently > hardcoded into ipuv3-crtc and we need to configure them to support more > TFT panels using the IPUV3 Parallel Display Interface. First, realise that what you're doing is configuring components within the IMX driver "suite" so what you need to do is communicate your requirements _only_ from parallel-display.c to ipuv3-crtc.c. There's already infrastructure in imx-drm for the display bridges to communicate various information to the CRTC layer - there's already the encoder type, and the "pins" for hsync/vsync being communicated via imx_drm_panel_format*(). This is really no different IMHO. _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
