Re: [PATCH v3 09/32] drm/exynos: Rename display_op power_on to dpms

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tuesday 29 of October 2013 12:12:55 Sean Paul wrote:
> This patch renames the display_op power_on to dpms to accurately reflect
> what the function does.
> 
> The side-effect of this patch is that the new hdmi dpms callback is now
> invoked twice in the dpms path. This is safe and will be dealt with when
> the exynos_drm shim goes away.
> 
> Signed-off-by: Sean Paul <seanpaul@xxxxxxxxxxxx>
> ---
> 
> Changes in v2: None
> Changes in v3:
> 	- Changed vidi to dpms as well
> 
>  drivers/gpu/drm/exynos/exynos_drm_drv.h     | 4 ++--
>  drivers/gpu/drm/exynos/exynos_drm_encoder.c | 4 ++--
>  drivers/gpu/drm/exynos/exynos_drm_fimd.c    | 8 --------
>  drivers/gpu/drm/exynos/exynos_drm_hdmi.c    | 8 ++++----
>  drivers/gpu/drm/exynos/exynos_drm_hdmi.h    | 3 +--
>  drivers/gpu/drm/exynos/exynos_drm_vidi.c    | 8 --------
>  drivers/gpu/drm/exynos/exynos_hdmi.c        | 2 +-
>  7 files changed, 10 insertions(+), 27 deletions(-)

Patch description fails to mention about removing dummy callbacks from 
FIMD and ViDi drivers, but that's just a nitpick, so:

Reviewed-by: Tomasz Figa <t.figa@xxxxxxxxxxx>

Best regards,
Tomasz

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux