Hello Jani, On Wed, 26 Feb 2025 14:26:09 +0200 Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx> wrote: > > Moving the last 2 lines to drm_bridge.c and into a new function we'd > > have: > > > > drm_encoder_register_all() [drm_encoder.c] > > -> drm_debugfs_encoder_add [*] [drm_debugfs.c] > > -> drm_bridge_debugfs_add_encoder_bridges_file (NEW) [drm_bridge.c] > > -> debugfs_create_file("bridges"... &bridges_fops) [drm_bridge.c] > > [bridges_fops is in drm_bridge.c] > > > > Potentially [*] could be moved to drm_encoder.c, but that is not bridge > > related and can be done as a future step. > > > > Is this what you had in mind? > > Yes! > > (Though I'd give drm_bridge_debugfs_add_encoder_bridges_file() a shorter > and more generic name.) Thanks, done. v8 on its way. Luca -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com