Re: [PATCH][next] drm/xe: Fix uninitialized pointer def

[Lucas De Marchi <lucas.demarchi@xxxxxxxxx>]

On Wed, Feb 26, 2025 at 04:05:24PM +0000, Colin Ian King wrote:
> In the case where a set of checks on xe->info.platform don't assign
> a value to pointer def the pointer remains uninitialized and hence
> can fail the following !def check. Fix this be ensuring pointer
> def is initialized to NULL.
>
> Fixes: 292b1a8a5054 ("drm/xe: Stop ignoring errors from xe_heci_gsc_init()")
> Signed-off-by: Colin Ian King <colin.i.king@xxxxxxxxx>


Reviewed-by: Lucas De Marchi <lucas.demarchi@xxxxxxxxx>

thanks
Lucas De Marchi

> ---
> drivers/gpu/drm/xe/xe_heci_gsc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_heci_gsc.c b/drivers/gpu/drm/xe/xe_heci_gsc.c
> index 3ea325d3db99..27d11e06a82b 100644
> --- a/drivers/gpu/drm/xe/xe_heci_gsc.c
> +++ b/drivers/gpu/drm/xe/xe_heci_gsc.c
> @@ -173,7 +173,7 @@ static int heci_gsc_add_device(struct xe_device *xe, const struct heci_gsc_def *
> int xe_heci_gsc_init(struct xe_device *xe)
> {
> 	struct xe_heci_gsc *heci_gsc = &xe->heci_gsc;
> -	const struct heci_gsc_def *def;
> +	const struct heci_gsc_def *def = NULL;
> 	int ret;
>
> 	if (!xe->info.has_heci_gscfi && !xe->info.has_heci_cscfi)
> --
> 2.47.2