On Wed, Nov 06, 2013 at 01:39:46PM +1000, Dave Airlie wrote: > > Here comes a collection of drm patches for qemu emulated > > virtual graphics cards. Small improvements for cirrus > > and qxl. A new kms driver for the qemu standard vga. > > > > Patches 1-4 can be queued up for merge, unless someone > > finds bugs / problems in review of course. > > Hi Gerd, > > I've merged 1-4, thanks for those. > > > > Patches 5+6 have known issues and are still work-in-progress. > > I'm posing them for early review nevertheless. > > Yeah I'm not really sure I like request_regions for drm drivers, yes > its nice to see things, but the fact > that we always get in trouble with efifb and vesafb and that people > seem to insist on later coming along > and supplying unhelpful patches to fix the lack of return checking, I > generally just steer clear. We've recently started to request_region the intel graphics stolen block. Surprising how much gunk the core pci resource layer loves to put in there, so caught a few real bugs. Also it's a major pain to actually get it to work (some random platform has an off-by-one apparently and fun stuff like that). But I agree that for the mmio bars it's probably not worth the trouble due to vesafb/efifb bonghits. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel