Hi Sean,
On Friday 01 of November 2013 15:50:05 Sean Paul wrote:
> On Thu, Oct 31, 2013 at 7:39 PM, Tomasz Figa <tomasz.figa@xxxxxxxxx>
wrote:
> > Hi Sean,
> >
> > On Tuesday 29 of October 2013 12:12:48 Sean Paul wrote:
[snip]
> >> -static void fimd_wait_for_vblank(struct device *dev)
> >> -{
> >> - struct fimd_context *ctx = get_fimd_context(dev);
> >> -
> >> - if (ctx->suspended)
> >> - return;
> >> -
> >> - atomic_set(&ctx->wait_vsync_event, 1);
> >> -
> >> - /*
> >> - * wait for FIMD to signal VSYNC interrupt or return after
> >> - * timeout which is set to 50ms (refresh rate of 20).
> >> - */
> >> - if (!wait_event_timeout(ctx->wait_vsync_queue,
> >> - !atomic_read(&ctx->wait_vsync_event),
> >> - DRM_HZ/20))
> >> - DRM_DEBUG_KMS("vblank wait timed out.\n");
> >> -}
> >
> > Do you need all the churn of moving all the functions above? I believe
> > it would be enough to simply move the structure. This would greatly
> > decrease the diffstat and chances of possible merge conflicts.
>
> Hi Tomasz,
> I've done as you suggest,
Thanks.
> I'll post a new version once we settle on
> the other issues you brought up.
Okay.
I'm yet to review remaining patches from this series (I hope to review
next 5-7 patches later today), as it is quite a lot of changes, so stay
tuned for further comments. ;)
Best regards,
Tomasz
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel
