Reviewed-by: Jacek Lawrynowicz <jacek.lawrynowicz@xxxxxxxxxxxxxxx>
On 12/13/2024 7:51 PM, Jeffrey Hugo wrote:
> From: Youssef Samir <quic_yabdulra@xxxxxxxxxxx>
>
> aic100_image_table is currently defined as a "const char *" array,
> this can potentially lead to the accidental modification of the
> pointers inside. Also, checkpatch.pl gives a warning about it.
>
> Change the type to a "const char * const" array to make the pointers
> immutable, preventing accidental modification of the images' paths.
>
> Signed-off-by: Youssef Samir <quic_yabdulra@xxxxxxxxxxx>
> Reviewed-by: Carl Vanderlip <quic_carlv@xxxxxxxxxxx>
> Reviewed-by: Jeffrey Hugo <quic_jhugo@xxxxxxxxxxx>
> Signed-off-by: Jeffrey Hugo <quic_jhugo@xxxxxxxxxxx>
> ---
> drivers/accel/qaic/sahara.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/accel/qaic/sahara.c b/drivers/accel/qaic/sahara.c
> index 21d58aed0deb..09c8b055aa81 100644
> --- a/drivers/accel/qaic/sahara.c
> +++ b/drivers/accel/qaic/sahara.c
> @@ -160,7 +160,7 @@ struct sahara_context {
> struct work_struct fw_work;
> struct work_struct dump_work;
> struct mhi_device *mhi_dev;
> - const char **image_table;
> + const char * const *image_table;
> u32 table_size;
> u32 active_image_id;
> const struct firmware *firmware;
> @@ -177,7 +177,7 @@ struct sahara_context {
> bool is_mem_dump_mode;
> };
>
> -static const char *aic100_image_table[] = {
> +static const char * const aic100_image_table[] = {
> [1] = "qcom/aic100/fw1.bin",
> [2] = "qcom/aic100/fw2.bin",
> [4] = "qcom/aic100/fw4.bin",
