On Wed, Oct 23, 2013 at 9:18 AM, Inki Dae <inki.dae@xxxxxxxxxxx> wrote: > Look at omapdrm, nouveau, and radeon drm drivers. btw, please don't look at omapdrm as a "good" example in this regard. The layering is really not a good idea and for a long time caused a lot of problems, which we essentially solved by bypassing parts of the layering. I still think omapdss and omapdrm should be flattened into a single drm driver, then net result would be a drop in # of lines of code. I wish there were folks like the Sean and Stéphane who cared enough to do this for omapdrm ;-) Other drivers have some modularity to separate code that is significantly different across genarations (but what form that takes differs depending on what how the hw differs across generations). This isn't a bad thing. But you need to look at the end result. For example how I split out the phy code for the mdp4 code in msm (hdmi and dsi phy differ between otherwise similar 28nm and 45nm parts, but the rest of the display controller blocks are basically the same). BR, -R _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
