On Tue, Oct 22, 2013 at 7:43 AM, Sylvain BERTRAND <sylware@xxxxxxxxxx> wrote: >>> commit 555b1b651acf44bf27ebbb04235d38a8fd2d58dc (drm-fixes-3.12) >>> >>> evergreen.c, SI code path, line 4045 and 4046 shouldn't be swapped? >>> Should cpu_to_le32 be used? >>> >>> Basically, is the endianness enforcement right for the rlc BOs? >>> Or is there a bit somewhere to switch the RLC to host >>> endianness? Or the kmap is swapping dwords? >> >> The rlc buffers should be little endian. They will need to be swapped >> on big endian systems. > > Right, then cpu_to_le32 should be used. > > Still for endianness, upper dword is written first (line 4045) and > lower dword is written second (line 4046): Should the lower dword be > written first then second the upper dword if we want little endian? > Or maybe in that specific case, the rlc expect the upper dword first? The rlc expects the upper 32 bits of the address in the lowest dword, followed by the lower 32 bits, followed by the buffer size. Alex _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
