On Sun, Dec 15, 2024 at 02:38:05PM +0200, Laurent Pinchart wrote:
> Hi Dmitry,
>
> Thank you for the patch.
>
> On Sun, Dec 15, 2024 at 01:09:08PM +0200, Dmitry Baryshkov wrote:
> > TDA998x is the HDMI bridge driver, incorporating drm_connector and
> > optional drm_encoder (created via the component bind API by the TICLDC
> > and HDLCD drivers). Thus it should be residing together with the other
> > DRM bridge drivers under drivers/gpu/drm/bridge/.
> >
> > TDA9950 is an I2C-CEC translator, being present on-die on the TDA9989
> > and TDA19989 chips, so it is being instantiated by the TDA998x driver.
> > Move it together with the TDA998x under bridge drivers subdir.
> >
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> > ---
> > MAINTAINERS | 2 +-
> > drivers/gpu/drm/arm/Kconfig | 1 +
> > drivers/gpu/drm/bridge/Kconfig | 2 ++
> > drivers/gpu/drm/bridge/Makefile | 1 +
> > drivers/gpu/drm/bridge/tda/Kconfig | 13 +++++++++++++
> > drivers/gpu/drm/bridge/tda/Makefile | 4 ++++
> > drivers/gpu/drm/{i2c => bridge/tda}/tda9950.c | 0
> > drivers/gpu/drm/{i2c => bridge/tda}/tda998x_drv.c | 0
>
> I probably wouldn't have created a tda/ subdirectory in bridge/, but I
> don't mind much either way.
I created it mostly because tda9950 isn't a bridge. It's a CEC driver
that works in pair with the tda998x driver.
> Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
--
With best wishes
Dmitry
