On Thu, Dec 12, 2024 at 09:49:19AM +0100, Jocelyn Falempe wrote: > On 12/12/2024 08:41, Dan Carpenter wrote: > > This patch breaks "make oldconfig" for me. It just gets into an endless > > loop of: > > > > Default DRM Client > > choice[1-0?]: 0 > > Default DRM Client > > choice[1-0?]: 0 > > Default DRM Client > > choice[1-0?]: 0 > > Default DRM Client > > choice[1-0?]: 0 > > ... > > > > I don't have to type anything, it just spams that forever. It's weird > > that it's 1-0 instead of 0-1. Does that means something? I don't know > > much about Kconfig. > > I can reproduce it with your provided config. > > It looks like it happens if DRM_CLIENT_SELECTION is enabled, but none of the > client is. > The attached patch should fix it, can you try it ? > > I will submit that shortly. > > Thanks for reporting it. > > Best regards, > > -- > > Jocelyn > > > > > > I'm using this arm64 randconfig as a base. I type "make oldconfig" and > > press enter until it gets to "Default DRM Client" and then it starts > > scrolling endlessly. > > https://download.01.org/0day-ci/archive/20241212/202412121555.Fp663tyH-lkp@xxxxxxxxx/config > > > > regards, > > dan carpenter > > > From e4d197debd2c199c9f2d8e35e41e36c2836926b9 Mon Sep 17 00:00:00 2001 > From: Jocelyn Falempe <jfalempe@xxxxxxxxxx> > Date: Thu, 12 Dec 2024 09:43:50 +0100 > Subject: [PATCH] Fix endless Kconfig loop > > Signed-off-by: Jocelyn Falempe <jfalempe@xxxxxxxxxx> Since I haven't seen the patch anywhere else I'll drop my ack here. Acked-by: Simona Vetter <simona.vetter@xxxxxxxx> Please push directly to drm-misc-next so the breakage doesn't linger. -Sima > --- > drivers/gpu/drm/clients/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/clients/Kconfig b/drivers/gpu/drm/clients/Kconfig > index c18decc90200..82a7d4e584dd 100644 > --- a/drivers/gpu/drm/clients/Kconfig > +++ b/drivers/gpu/drm/clients/Kconfig > @@ -87,6 +87,7 @@ config DRM_CLIENT_LOG > choice > prompt "Default DRM Client" > depends on DRM_CLIENT_SELECTION > + depends on DRM_FBDEV_EMULATION || DRM_CLIENT_LOG > default DRM_CLIENT_DEFAULT_FBDEV > help > Selects the default drm client. > -- > 2.47.1 > -- Simona Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
