Hello Conor, On Fri, 2024-12-06 at 17:14 +0000, Conor Dooley wrote: > > Add Texas Instruments' LP8864/LP8866 bindings into LP8860 converting them > > into YAML format simultaneously. While here, drop the index of the "led" > > subnode, this one is neither used nor mandated by the drivers. All the > > *-cells properties are therefore not required. > > Are you sure this is a correct thing to do? The lp8860-q1 product link > cites it as being a 4-channel device. Even if the kernel only ever > supports it as a single-channel device, the binding should reflect what > it is capable of doing. my understanding is: - The whole family is multi-channel (4 or 6), but this is rather used internally in the chip for power balancing; separate diagnostics is provided. From the user perspective one has only one brightness per chip. - The lp8860 driver didn't attempt to do anything with the index. I'm glad Andrew Davis had a time for a pre-public review of the new binding and actually suggested this simplification. -- Alexander Sverdlin Siemens AG www.siemens.com
