On Mon, Nov 11, 2024 at 10:41 PM Jani Nikula
<jani.nikula@xxxxxxxxxxxxxxx> wrote:
>
> On Mon, 11 Nov 2024, Huacai Chen <chenhuacai@xxxxxxxxxxx> wrote:
> > Commit dbbfaf5f2641a ("drm: Remove bridge support from legacy helpers")
> > removes the drm_bridge_mode_fixup() call in drm_crtc_helper_set_mode(),
> > which makes the subsequent "encoder_funcs = encoder->helper_private" be
> > redundant, so remove it.
> >
> > Cc: stable@xxxxxxxxxxxxxxx
> > Fixes: dbbfaf5f2641a ("drm: Remove bridge support from legacy helpers")
>
> IMO not necessary because nothing's broken, it's just redundant.
Maintainer is free to keep or remove the Cc and Fixes tag. :)
Huacai
>
> Reviewed-by: Jani Nikula <jani.nikula@xxxxxxxxx>
>
> > Signed-off-by: Huacai Chen <chenhuacai@xxxxxxxxxxx>
> > ---
> > drivers/gpu/drm/drm_crtc_helper.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/drm_crtc_helper.c b/drivers/gpu/drm/drm_crtc_helper.c
> > index 0955f1c385dd..39497493f74c 100644
> > --- a/drivers/gpu/drm/drm_crtc_helper.c
> > +++ b/drivers/gpu/drm/drm_crtc_helper.c
> > @@ -334,7 +334,6 @@ bool drm_crtc_helper_set_mode(struct drm_crtc *crtc,
> > if (!encoder_funcs)
> > continue;
> >
> > - encoder_funcs = encoder->helper_private;
> > if (encoder_funcs->mode_fixup) {
> > if (!(ret = encoder_funcs->mode_fixup(encoder, mode,
> > adjusted_mode))) {
>
> --
> Jani Nikula, Intel
