Re: [PATCH v3 08/10] ARM: dts: ti: omap: samsung-espresso7: Add initial support for Galaxy Tab 2 7.0

[Andreas Kemnade <andreas@xxxxxxxxxxxx>]

Hi Mithil,

Am Fri,  8 Nov 2024 20:04:37 +0000
schrieb Mithil Bavishi <bavishimithil@xxxxxxxxx>:

> Create a device tree for the 7 inch variants (P3100, P3110, P3113)
> 
> Signed-off-by: Mithil Bavishi <bavishimithil@xxxxxxxxx>
> ---
>  .../dts/ti/omap/omap4-samsung-espresso7.dts   | 70 +++++++++++++++++++
>  1 file changed, 70 insertions(+)
>  create mode 100644 arch/arm/boot/dts/ti/omap/omap4-samsung-espresso7.dts
> 
> diff --git a/arch/arm/boot/dts/ti/omap/omap4-samsung-espresso7.dts b/arch/arm/boot/dts/ti/omap/omap4-samsung-espresso7.dts
> new file mode 100644
> index 000000000..be3d7a82f
> --- /dev/null
> +++ b/arch/arm/boot/dts/ti/omap/omap4-samsung-espresso7.dts
> @@ -0,0 +1,70 @@
> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> +/dts-v1/;
> +
> +#include "omap4-samsung-espresso-common.dtsi"
> +
> +/ {
> +	model = "Samsung Galaxy Tab 2 (7 inch)";
> +	compatible = "samsung,espresso7", "ti,omap4430", "ti,omap4";
> +
> +	backlight: backlight {
> +		compatible = "pwm-backlight";
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&backlight_pins>;
> +		pwms = <&pwm10 0 1200 0>;
> +		power-supply = <&reg_lcd>;
> +		enable-gpios = <&gpio3 31 GPIO_ACTIVE_HIGH>;
> +		brightness-levels = <0 4 8 16 32 64 128 255>;
> +		default-brightness-level = <2>;
> +	};
> +
> +	panel {
> +		compatible = "samsung,ltn070nl01", "panel-lvds";
> +		power-supply = <&reg_lcd>;
> +		width-mm = <154>;
> +		height-mm = <90>;
> +		data-mapping = "vesa-24";
> +		backlight = <&backlight>;
> +
> +		panel-timing {
> +			clock-frequency = <47255554>;
> +
> +			hback-porch = <210>;
> +			hactive = <1024>;
> +			hfront-porch = <186>;
> +			hsync-len = <50>;
> +
> +			vback-porch = <11>;
> +			vactive = <600>;
> +			vfront-porch = <24>;
> +			vsync-len = <10>;
> +
> +			hsync-active = <0>;
> +			vsync-active = <0>;
> +			de-active = <1>;
> +			pixelclk-active = <1>;
> +			syncclk-active = <0>;
> +		};
> +
> +		port {
> +			panel_in: endpoint {
> +				remote-endpoint = <&bridge_out>;
> +			};
> +		};
> +	};
> +};
> +
> +&i2c3 {
> +	touchscreen@48 {
> +		compatible = "melfas,mms136";
> +		reg = <0x48>;
> +		interrupt-parent = <&gpio2>;
> +		interrupts = <14 IRQ_TYPE_EDGE_FALLING>;
> +		touchscreen-size-x = <1023>;

Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml:
horizontal resolution of touchscreen (maximum x coordinate reported + 1)

So this touchscreen reports max 1022?

> +		touchscreen-size-y = <599>;

same question.

Regards,
Andreas