On Mon, Oct 7, 2013 at 12:47 PM, Rafał Miłecki <zajec5@xxxxxxxxx> wrote: > 2013/10/7 Alex Deucher <alexdeucher@xxxxxxxxx>: >> On Sun, Oct 6, 2013 at 4:46 PM, Rafał Miłecki <zajec5@xxxxxxxxx> wrote: >>> Write to HDMI_VBI_PACKET_CONTROL was duplicated. >>> Writes to AFMT_AUDIO_CRC_CONTROL and AFMT_RAMP_CONTROL[0-3] came from >>> DCE2/3 code (copy & paste) and were never needed on DCE4+. >>> >>> See https://bugzilla.kernel.org/show_bug.cgi?id=62591 for details. >> >> I think in general it would be better to do a read/modify/write >> sequences for all hdmi register updates rather than just writing. >> That's generally what the hw team recommends and what the catalyst >> driver does. > > See my patch 3/2 for that :) I agree with you. Patch set looks good. Let me know if you have any further questions about the registers. Alex _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
