Hi Thomas, These commit logs are nicely explained -- thanks a lot for taking the time to write each! A couple nits below. On Sat, Oct 12, 2024 at 9:53 AM Thomas Böhler <witcher@xxxxxxxxxxxxx> wrote: > > implementing the same logic itself. > Clippy complains about this in the `manual_find` lint: Typically commit messages use newlines between paragraphs. > Reported-by: Miguel Ojeda <ojeda@xxxxxxxxxx> > Closes: https://github.com/Rust-for-Linux/linux/issues/1123 Since each of these commits fixes part of the issue, I think these are meant to be `Link:`s instead of `Closes:`s according to the docs: https://docs.kernel.org/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes In addition, these should probably have a `Fixes:` tag too -- I should have mentioned that in the issue, sorry. Finally, as a suggestion for the future: for a series like this, it may make sense to have a small/quick cover letter saying something as simple as: "Clippy reports some issues in ... -- this series cleans them up.". Having a cover letter also allows you to give a title to the series. Thanks again! Cheers, Miguel
