On 08/10/2024 09:45, Uwe Kleine-König wrote: > After commit 0edb555a65d1 ("platform: Make platform_driver::remove() > return void") .remove() is (again) the right callback to implement for > platform drivers. > > Convert all platform drivers below drivers/gpu/drm/ to use .remove(), > with the eventual goal to drop struct platform_driver::remove_new(). As > .remove() and .remove_new() have the same prototypes, conversion is done > by just changing the structure member name in the driver initializer. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxx> > --- > Hello, > > given the simplicity of the individual changes I do this all in a single > patch. I you don't agree, please tell and I will happily split it. > > It's based on Friday's next, feel free to drop changes that result in a > conflict when you come around to apply this. I'll care for the fallout > at a later time then. (Having said that, if you use b4 am -3 and git am > -3, there should be hardly any conflict.) > > Note I didn't Cc: all the individual driver maintainers to not trigger > sending limits and spam filters. > > Best regards > Uwe > > [snip] > > diff --git a/drivers/gpu/drm/imagination/pvr_drv.c b/drivers/gpu/drm/imagination/pvr_drv.c > index 684a9b9a2247..6a27318ecb82 100644 > --- a/drivers/gpu/drm/imagination/pvr_drv.c > +++ b/drivers/gpu/drm/imagination/pvr_drv.c > @@ -1482,7 +1482,7 @@ static const struct dev_pm_ops pvr_pm_ops = { > > static struct platform_driver pvr_driver = { > .probe = pvr_probe, > - .remove_new = pvr_remove, > + .remove = pvr_remove, > .driver = { > .name = PVR_DRIVER_NAME, > .pm = &pvr_pm_ops, I don't know if you need and/or want individual RBs from individual driver maintainers, but just in case: Reviewed-By: Matt Coster <matt.coster@xxxxxxxxxx> [imagination] > [snip] > > base-commit: 58ca61c1a866bfdaa5e19fb19a2416764f847d75 -- Matt Coster E: matt.coster@xxxxxxxxxx
Attachment:
OpenPGP_signature.asc
Description: OpenPGP digital signature