On 9/26/24 11:57, Ville Syrjälä wrote:
On Thu, Sep 26, 2024 at 08:08:07AM +0200, Helge Deller wrote:
Hi Ville,
On 9/23/24 17:57, Ville Syrjala wrote:
Currently setting cursor_blink attribute to 0 before any fb
devices are around does absolutely nothing. When fb devices appear
and fbcon becomes active the cursor starts blinking. Fix the problem
by recoding the desired state of the attribute even if no fb devices
are present at the time.
Also adjust the show() method such that it shows the current
state of the attribute even when no fb devices are in use.
Note that store_cursor_blink() is still a bit dodgy:
- seems to be missing some of the other checks that we do
elsewhere when deciding whether the cursor should be
blinking or not
- when set to 0 when the cursor is currently invisible due
to blinking, the cursor will remains invisible. We should
either explicitly make it visible here, or wait until the
full blink cycle has finished.
are you planning to send follow-up patches to address those shortcomings?
Nope. I don't really care about those as I never plan to
turn the cursor blinking back on after turning it off via
udev.
Sad, but OK. I will look into this when I find time.
I'd hoped to push those patches upstream during this merge window,
but then I think I have to delay them at least until kernel 6.13.
Thanks!
Helge
