Hi Andy,
On 9/20/24 10:16, Andy Yan wrote:
> [...]
A few minor nitpicks:
> Andy Yan (15):
> drm/rockchip: vop2: Add debugfs support
There is an extra space in the extended commit message ("...summary:
dump..." -> "...summary: dump...".
> drm/rockchip: Set dma mask to 64 bit
> drm/rockchip: vop2: Fix cluster windows alpha ctrl regsiters offset
Typo "regsiters" -> "registers".
> drm/rockchip: vop2: Fix the mixer alpha setup for layer 0
> drm/rockchip: vop2: Fix the windows switch between different layers
> drm/rockchip: vop2: include rockchip_drm_drv.h
> drm/rockchip: vop2: Support 32x8 superblock afbc
> drm/rockchip: vop2: Add platform specific callback
> drm/rockchip: vop2: Support for different layer selet configuration
Typo "selet" -> "select"?
> between VPs
> drm/rockchip: vop2: Introduce vop hardware version
> drm/rockchip: vop2: Register the primary plane and overlay plane
> separately
> drm/rockchip: vop2: Set plane possible crtcs by possible vp mask
> drm/rockchip: vop2: Add uv swap for cluster window
> dt-bindings: display: vop2: Add rk3576 support
> drm/rockchip: vop2: Add support for rk3576
>
> .../display/rockchip/rockchip-vop2.yaml | 13 +-
> drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 4 +-
> drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 1572 ++++---------
> drivers/gpu/drm/rockchip/rockchip_drm_vop2.h | 274 ++-
> drivers/gpu/drm/rockchip/rockchip_vop2_reg.c | 1948 ++++++++++++++++-
> 5 files changed, 2683 insertions(+), 1128 deletions(-)
I gave your changes a quick test on my RK3568 device and did not find
any regressions ->
Tested-by: Michael Riesch <michael.riesch@xxxxxxxxxxxxxx> # on RK3568
Thanks and best regards,
Michael
