Re: [patch] drm/radeon: forever loop on error in radeon_do_test_moves()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jul 1, 2013 at 12:39 PM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> The error path does this:
>
>         for (--i; i >= 0; --i) {
>
> which is a forever loop because "i" is unsigned.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Sorry I missed this one.  Applied.

Thanks!

Alex

>
> diff --git a/drivers/gpu/drm/radeon/radeon_test.c b/drivers/gpu/drm/radeon/radeon_test.c
> index f4d6bce..12e8099 100644
> --- a/drivers/gpu/drm/radeon/radeon_test.c
> +++ b/drivers/gpu/drm/radeon/radeon_test.c
> @@ -36,8 +36,8 @@ static void radeon_do_test_moves(struct radeon_device *rdev, int flag)
>         struct radeon_bo *vram_obj = NULL;
>         struct radeon_bo **gtt_obj = NULL;
>         uint64_t gtt_addr, vram_addr;
> -       unsigned i, n, size;
> -       int r, ring;
> +       unsigned n, size;
> +       int i, r, ring;
>
>         switch (flag) {
>         case RADEON_TEST_COPY_DMA:
> _______________________________________________
> dri-devel mailing list
> dri-devel@xxxxxxxxxxxxxxxxxxxxx
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux