Re: [PATCH 2/2] drm/i915/gt: Fixed an typo

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Zhang He,

I merged your previous patch so that you don't need to resend it
anymore.

I already asked you not to resend it in the past version. Please,
read carefully the comments you receive.

I repeat: add the versioning. When you do:

   git format patch ...

you get:

   [PATCH 1/1] drm/....

if you do

   git format patch -v 2 ...

you get:

   [PATCH v2 1/1] drm/....

This is what I asked you to do.

The 1/1 or 2/2 is the patch counter for multi patch series, not
the version. The version is given by "-v 2" from the git
format-patch command.

Please read the SubmittingPatches document, it's essential for
sending patches.

On Sat, Sep 14, 2024 at 09:31:46AM GMT, Zhang He wrote:
> column header should be GPU, not CPU
> 
> ---
> ChangeLog:
>     v1: use correct name as Author and Signer
>     v2: change one line in drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c,
>         LLC's information header from "Effective CPU freq" to "Effective GPU freq"

Good that the changelog is here. The v2, though, is not a
changelog, but a description.

> Signed-off-by: Zhang He <zhanghe9702@xxxxxxx>

The signature goes above the "---" section, otherwise it doesn't
show up when I apply the patch.

Thanks for your patch,
Andi



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux