Hi Sui,
On Wed, May 29, 2024 at 1:31 PM Sui Jingfeng <sui.jingfeng@xxxxxxxxx> wrote:
> On 5/27/24 21:34, Geert Uytterhoeven wrote:
> > Add support for the drm_panic module, which displays a message on
> > the screen when a kernel panic occurs.
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> > Reviewed-by: Jocelyn Falempe <jfalempe@xxxxxxxxxx>
>
> Acked-by: Sui Jingfeng <sui.jingfeng@xxxxxxxxx>
Thank you!
> > --- a/drivers/gpu/drm/renesas/shmobile/shmob_drm_plane.c
> > +++ b/drivers/gpu/drm/renesas/shmobile/shmob_drm_plane.c
> > @@ -273,6 +273,13 @@ static const struct drm_plane_helper_funcs shmob_drm_plane_helper_funcs = {
> > .atomic_disable = shmob_drm_plane_atomic_disable,
> > };
> >
> > +static const struct drm_plane_helper_funcs shmob_drm_primary_plane_helper_funcs = {
> > + .atomic_check = shmob_drm_plane_atomic_check,
> > + .atomic_update = shmob_drm_plane_atomic_update,
> > + .atomic_disable = shmob_drm_plane_atomic_disable,
> > + .get_scanout_buffer = drm_fb_dma_get_scanout_buffer,
> > +};
> > +
> > static const struct drm_plane_funcs shmob_drm_plane_funcs = {
> > .update_plane = drm_atomic_helper_update_plane,
> > .disable_plane = drm_atomic_helper_disable_plane,
> > @@ -310,7 +317,12 @@ struct drm_plane *shmob_drm_plane_create(struct shmob_drm_device *sdev,
>
>
> Maybe a shmob_drm_plane_create_primary_plane() plus a
> shmob_drm_plane_create_overlay().
>
> I remember Thomas told this way or something similiar, call untangle.
Hmm, that's what we had until commit c228823426ae509f ("drm:
renesas: shmobile: Unify plane allocation")...
>
> > splane->index = index;
> >
> > - drm_plane_helper_add(&splane->base, &shmob_drm_plane_helper_funcs);
> > + if (type == DRM_PLANE_TYPE_PRIMARY)
> > + drm_plane_helper_add(&splane->base,
> > + &shmob_drm_primary_plane_helper_funcs);
> > + else
> > + drm_plane_helper_add(&splane->base,
> > + &shmob_drm_plane_helper_funcs);
> >
> > return &splane->base;
> > }
>
>
> Anyway, it looks good to me.
Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
