Hi, On Wed, Jul 24, 2024 at 12:51 AM Neil Armstrong <neil.armstrong@xxxxxxxxxx> wrote: > > >> @@ -0,0 +1,240 @@ > >> +// SPDX-License-Identifier: GPL-2.0-only > >> +// Generated with linux-mdss-dsi-panel-driver-generator from vendor device tree: > >> +// Copyright (c) 2013, The Linux Foundation. All rights reserved. > >> +// Copyright (c) 2024, Neil Armstrong <neil.armstrong@xxxxxxxxxx> > >> + > >> +#include <linux/delay.h> > >> +#include <linux/gpio/consumer.h> > >> +#include <linux/regulator/consumer.h> > >> +#include <linux/module.h> > >> +#include <linux/of.h> > > > > nit: sort header files? > > Will do while I'm it, but I don't personally care of the include order.. FWIW: the main reason I push for sorting in cases like this is to avoid merge conflicts as the driver changes. If everyone adds new #includes at the end then every change will cause a merge conflict. If things are kept sorted it's still possible to get a merge conflict but the number goes down. Probably not super relevant in such a simple driver but just the policy I push for in general. The criteria for sorting doesn't matter to me (some people put "nested" includes in separate sections and some just do a normal sort) as long as it's obvious / consistent for a given file. -Doug
