On 6/25/2024 1:24 PM, Dmitry Baryshkov wrote:
From: Bjorn Andersson <andersson@xxxxxxxxxx> Some platforms provides a mechanism for configuring the mapping between (one or two) DisplayPort intfs and their PHYs. In particular SC8180X requires this to be configured, since on this platform there are fewer controllers than PHYs. The change implements the logic for optionally configuring which PHY each of the DP INTFs should be connected to and marks the SC8180X DPU to program 2 entries. For now the request is simply to program the mapping 1:1, any support for alternative mappings is left until the use case arrise. Note that e.g. msm-4.14 unconditionally maps INTF 0 to PHY 0 on all platforms, so perhaps this is needed in order to get DisplayPort working on some other platforms as well. Signed-off-by: Bjorn Andersson <andersson@xxxxxxxxxx> Co-developed-by: Bjorn Andersson <andersson@xxxxxxxxxx> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> --- Changes in v3: - Expanded the commit message and in-code comment based on feedback from Abhinav - Fixed field masks for the affected register (Abhinav) - Link to v2: https://lore.kernel.org/r/20240613-dp-phy-sel-v2-1-99af348c9bae@xxxxxxxxxx Changes in v2: - Removed entry from the catalog. - Reworked the interface of dpu_hw_dp_phy_intf_sel(). Pass two entries for the PHYs instead of three entries. - It seems the register isn't present on sdm845, enabled the callback only for DPU >= 5.x - Added a comment regarding the data being platform-specific. - Link to v1: https://lore.kernel.org/r/20230612221047.1886709-1-quic_bjorande@xxxxxxxxxxx --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_top.c | 39 +++++++++++++++++++++++++++--- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_top.h | 18 ++++++++++++-- drivers/gpu/drm/msm/disp/dpu1/dpu_hwio.h | 7 ++++++ drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 12 ++++++++- 4 files changed, 70 insertions(+), 6 deletions(-)
LGTM. Reviewed-by: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx>
