On Mon, May 27, 2024 at 06:06:05PM +0200, Marc Gonzalez wrote:
> From: Arnaud Vrac <avrac@xxxxxxxxxx>
>
> The TI TDP158 is an AC-Coupled HDMI signal to TMDS Redriver supporting
> DVI 1.0 and HDMI 1.4b and 2.0b output signals.
>
> Since it's an I2C-programmable bridge, it could have a proper driver,
> but the default settings work fine, thus simple bridge is sufficient.
>
> Signed-off-by: Arnaud Vrac <avrac@xxxxxxxxxx>
> Signed-off-by: Marc Gonzalez <mgonzalez@xxxxxxxxxx>
> ---
> Change in v2: send from correct address
> ---
> drivers/gpu/drm/bridge/simple-bridge.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/bridge/simple-bridge.c b/drivers/gpu/drm/bridge/simple-bridge.c
> index 5813a2c4fc5ee..b138279864750 100644
> --- a/drivers/gpu/drm/bridge/simple-bridge.c
> +++ b/drivers/gpu/drm/bridge/simple-bridge.c
> @@ -292,6 +292,11 @@ static const struct of_device_id simple_bridge_match[] = {
> .timings = &ti_ths8134_bridge_timings,
> .connector_type = DRM_MODE_CONNECTOR_VGA,
> },
> + }, {
> + .compatible = "ti,tdp158",
> + .data = &(const struct simple_bridge_info) {
> + .connector_type = DRM_MODE_CONNECTOR_HDMIA,
Bindings please. Also, note that per the datasheet the bridge uses two
supplies, Vcc for 3.3V and Vdd for 1.1V, so it doesn't fully fit the
simple-bridge.c (which might need to be adjusted for the second supply).
Chapter 7.3.2 of the datasheet points out that Vcc should be brought up
before Vdd.
> + },
> },
> {},
> };
> --
> 2.34.1
--
With best wishes
Dmitry
