On 08/28/2013 03:30 PM, Thierry Reding wrote:
* PGP Signed by an unknown key
On Wed, Aug 28, 2013 at 01:40:59PM +0300, Mikko Perttunen wrote:
Add hdmi node to Dalmore device tree to supply Dalmore-specific
s/hdmi/HDMI/
Will fix.
diff --git a/arch/arm/boot/dts/tegra114-dalmore.dts b/arch/arm/boot/dts/tegra114-dalmore.dts
[...]
+ host1x {
+ hdmi {
+ status = "okay";
+
+ vdd-supply = <&vdd_hdmi_reg>;
+ pll-supply = <&palmas_smps3_reg>;
+ nvidia,ddc-i2c-bus = <&hdmi_ddc>;
I prefer to use a blank line to separate "standard" from
"vendor-specific" properties.
Will fix.
+ nvidia,hpd-gpio = <&gpio TEGRA_GPIO(N, 7) GPIO_ACTIVE_HIGH>;
Other .dts files split this so it doesn't exceed 80 characters. I'm not
sure how useful that is as a general rule for DT source files, though.
Will fix. I guess check_patch.pl doesn't check for line length in *.dts.
i2c@7000d000 {
status = "okay";
clock-frequency = <400000>;
@@ -1169,6 +1184,8 @@
regulator-min-microvolt = <5000000>;
regulator-max-microvolt = <5000000>;
enable-active-high;
+ regulator-always-on;
+ regulator-boot-on;
This warrants at least a mention in the commit message.
Hmm, yeah. Looks like the HDMI driver only enables the Vdd in
tegra_output_hdmi_enable, which is too late at least for DDC. I guess a
better patch would be to enable it earlier. In _probe?
Thierry
* Unknown Key
* 0x7F3EB3A1
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel
