On Tue, Aug 20, 2013 at 07:56:42AM -0700, Ian Romanick wrote:
> On 08/19/2013 04:53 PM, Damien Lespiau wrote:
> >It's only used in drm_platform.c.
> >
> >Signed-off-by: Damien Lespiau <damien.lespiau@xxxxxxxxx>
> >---
> > drivers/gpu/drm/drm_platform.c | 7 +++----
> > include/drm/drmP.h | 3 ---
> > 2 files changed, 3 insertions(+), 7 deletions(-)
> >
> >diff --git a/drivers/gpu/drm/drm_platform.c b/drivers/gpu/drm/drm_platform.c
> >index b8a282e..400024b 100644
> >--- a/drivers/gpu/drm/drm_platform.c
> >+++ b/drivers/gpu/drm/drm_platform.c
> >@@ -28,7 +28,7 @@
> > #include <linux/export.h>
> > #include <drm/drmP.h>
> >
> >-/**
> >+/*
> > * Register.
> > *
> > * \param platdev - Platform device struture
>
> Was this change intentional? The rest of the comment is doxygen still.
It was indeed, just to stop documentation tools from picking up that
symbol that is not exported anymore. The documentation blob still
contains markup to tag the parameters though, might as well leave it
there.
--
Damien
>
> >@@ -39,8 +39,8 @@
> > * Try and register, if we fail to register, backout previous work.
> > */
> >
> >-int drm_get_platform_dev(struct platform_device *platdev,
> >- struct drm_driver *driver)
> >+static int drm_get_platform_dev(struct platform_device *platdev,
> >+ struct drm_driver *driver)
> > {
> > struct drm_device *dev;
> > int ret;
> >@@ -107,7 +107,6 @@ err_g1:
> > mutex_unlock(&drm_global_mutex);
> > return ret;
> > }
> >-EXPORT_SYMBOL(drm_get_platform_dev);
> >
> > static int drm_platform_get_irq(struct drm_device *dev)
> > {
> >diff --git a/include/drm/drmP.h b/include/drm/drmP.h
> >index 046a7db..1a7a78f 100644
> >--- a/include/drm/drmP.h
> >+++ b/include/drm/drmP.h
> >@@ -1657,9 +1657,6 @@ extern int drm_pcie_get_speed_cap_mask(struct drm_device *dev, u32 *speed_mask);
> > extern int drm_platform_init(struct drm_driver *driver, struct platform_device *platform_device);
> > extern void drm_platform_exit(struct drm_driver *driver, struct platform_device *platform_device);
> >
> >-extern int drm_get_platform_dev(struct platform_device *pdev,
> >- struct drm_driver *driver);
> >-
> > /* returns true if currently okay to sleep */
> > static __inline__ bool drm_can_sleep(void)
> > {
> >
>
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel
