On Mon, 4 Mar 2024 12:31:23 +0000 Steven Price <steven.price@xxxxxxx> wrote: > On 04/03/2024 09:08, Boris Brezillon wrote: > > Something on arm[64] must be including <asm/page.h>, but things fail > > to compile on sparc64. Make sure this header is included explicitly > > so this driver can be compile-tested on all supported architectures. > > > > Reported-by: kernel test robot <lkp@xxxxxxxxx> > > Closes: https://lore.kernel.org/oe-kbuild-all/202403031142.Vl4pW7X6-lkp@xxxxxxxxx/ > > Signed-off-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx> > > Seems reasonable, although I do wonder if it's right to include a "asm" > header here or if we should pull in something like "linux/mm.h" which > includes asm/page.h. I can find examples of both. Either way: Actually, I considered including linux/mm.h too, so I'm happy to go for this option (will fix when applying. > > Reviewed-by: Steven Price <steven.price@xxxxxxx> > > > --- > > drivers/gpu/drm/panthor/panthor_device.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/gpu/drm/panthor/panthor_device.c b/drivers/gpu/drm/panthor/panthor_device.c > > index bfe8da4a6e4c..68e467ee458a 100644 > > --- a/drivers/gpu/drm/panthor/panthor_device.c > > +++ b/drivers/gpu/drm/panthor/panthor_device.c > > @@ -3,6 +3,8 @@ > > /* Copyright 2019 Linaro, Ltd, Rob Herring <robh@xxxxxxxxxx> */ > > /* Copyright 2023 Collabora ltd. */ > > > > +#include <asm/page.h> > > + > > #include <linux/clk.h> > > #include <linux/platform_device.h> > > #include <linux/pm_domain.h> >
