On Mon, 26 Feb 2024 17:23:24 +0000 Dave Stevenson <dave.stevenson@xxxxxxxxxxxxxxx> wrote: > Hi Pekka > > Sorry for the slight delay in replying. > > On Mon, 26 Feb 2024 at 15:11, Pekka Paalanen > <pekka.paalanen@xxxxxxxxxxxxx> wrote: > > > > On Mon, 26 Feb 2024 15:10:45 +0100 > > Maxime Ripard <mripard@xxxxxxxxxx> wrote: > > > > > Hi Pekka, > > > > > > On Wed, Feb 21, 2024 at 11:07:51AM +0200, Pekka Paalanen wrote: > > > > On Fri, 16 Feb 2024 18:48:55 +0000 > > > > Dave Stevenson <dave.stevenson@xxxxxxxxxxxxxxx> wrote: > > > > > > > > > From: Nick Hollinghurst <nick.hollinghurst@xxxxxxxxxxxxxxx> > > > > > > > > > > Add this as a value for enum_drm_connector_tv_mode, represented > > > > > by the string "Mono", to generate video with no colour encoding > > > > > or bursts. Define it to have no pedestal (since only NTSC-M calls > > > > > for a pedestal). > > > > > > > > > > Change default mode creation to acommodate the new tv_mode value > > > > > which comprises both 525-line and 625-line formats. > > > > > > > > > > Signed-off-by: Nick Hollinghurst <nick.hollinghurst@xxxxxxxxxxxxxxx> > > > > > Signed-off-by: Dave Stevenson <dave.stevenson@xxxxxxxxxxxxxxx> > > > > > > > > since no-one else commented yet, I'd like to remind of the new UAPI > > > > requirements: > > > > https://dri.freedesktop.org/docs/drm/gpu/drm-uapi.html#open-source-userspace-requirements > > > > > > > > AFAIU, adding a new value to an existing enum still counts as new UAPI. > > > > > > > > Maybe there is no need for the full treatment here, or maybe there is, > > > > I'm not sure. I think you should make some statement about how the new > > > > UAPI requirements have been addressed. ... > The use cases for runtime switching of the "tv_mode" are exceedingly > rare, so IMHO the property doesn't need exposing through the UAPI. > However it was added to the UAPI about 8 years ago for vc4 and sunxi, > and is also now used by other drivers, so can't be reverted. Does that > mean it can now never be changed without jumping through the hoop of > creating some userspace user? That is for the DRM maintainers to decide. For that, they must first notice that this is indeed new UAPI. History has shown that UAPI changes sometimes get through when they would have probably been rejected off-hand if a maintainer had a proper look. I saw an UAPI addition that was not in any way highlighted as such, with a topic that is probably uninteresting to most. The patch also did not discuss any of the details you now explained, which could serve as a justification. Naturally I screamed, hoping to attract maintainer attention. Thanks, pq > > Regards > Dave > > [3] https://elixir.bootlin.com/linux/latest/source/drivers/gpu/drm/drm_modes.c#L2232
Attachment:
pgpQeFTx5b5AN.pgp
Description: OpenPGP digital signature
