Re: [PATCH 5/7] drm/radeon: remove stale gem->driver_private access

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Aug 14, 2013 at 9:07 AM, David Herrmann <dh.herrmann@xxxxxxxxx> wrote:
> This field is never read. No need to set it in radeon. Besides, DRM gem
> core clears it during setup, anyway.
>
> Cc: Dave Airlie <airlied@xxxxxxxxx>
> Cc: Alex Deucher <alexdeucher@xxxxxxxxx>
> Signed-off-by: David Herrmann <dh.herrmann@xxxxxxxxx>

Reviewed-by: Alex Deucher <alexander.deucher@xxxxxxx>

> ---
>  drivers/gpu/drm/radeon/radeon_object.c | 1 -
>  drivers/gpu/drm/radeon/radeon_prime.c  | 1 -
>  2 files changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_object.c b/drivers/gpu/drm/radeon/radeon_object.c
> index 2020bf4..c0fa4aa 100644
> --- a/drivers/gpu/drm/radeon/radeon_object.c
> +++ b/drivers/gpu/drm/radeon/radeon_object.c
> @@ -142,7 +142,6 @@ int radeon_bo_create(struct radeon_device *rdev,
>                 return r;
>         }
>         bo->rdev = rdev;
> -       bo->gem_base.driver_private = NULL;
>         bo->surface_reg = -1;
>         INIT_LIST_HEAD(&bo->list);
>         INIT_LIST_HEAD(&bo->va);
> diff --git a/drivers/gpu/drm/radeon/radeon_prime.c b/drivers/gpu/drm/radeon/radeon_prime.c
> index 65b9eab..2007456 100644
> --- a/drivers/gpu/drm/radeon/radeon_prime.c
> +++ b/drivers/gpu/drm/radeon/radeon_prime.c
> @@ -68,7 +68,6 @@ struct drm_gem_object *radeon_gem_prime_import_sg_table(struct drm_device *dev,
>                                RADEON_GEM_DOMAIN_GTT, sg, &bo);
>         if (ret)
>                 return ERR_PTR(ret);
> -       bo->gem_base.driver_private = bo;
>
>         mutex_lock(&rdev->gem.mutex);
>         list_add_tail(&bo->list, &rdev->gem.objects);
> --
> 1.8.3.4
>
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux