On Mon, Aug 05, 2013 at 02:36:47PM +0100, Damien Lespiau wrote: > >From CEA-861: > > Data Byte 1, bit A0 indicates whether Active Format Data is present in > Data Byte 2 bits R3 through R0. A source device shall set A0=1 when > any of the AFD bits are set. > > ie. if we want to set active_aspect, we need to set the > active_info_valid bit to 1 as well. > > Cc: Thierry Reding <thierry.reding@xxxxxxxxxxxxxxxxx> > Signed-off-by: Damien Lespiau <damien.lespiau@xxxxxxxxx> Reviewed-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> But why don't we just kill active_info_valid and instead just check active_aspect in hdmi_avi_infoframe_pack()? > --- > drivers/gpu/drm/drm_edid.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c > index 95d6f4b..8d1139f 100644 > --- a/drivers/gpu/drm/drm_edid.c > +++ b/drivers/gpu/drm/drm_edid.c > @@ -3107,6 +3107,7 @@ drm_hdmi_avi_infoframe_from_display_mode(struct hdmi_avi_infoframe *frame, > return 0; > > frame->picture_aspect = HDMI_PICTURE_ASPECT_NONE; > + frame->active_info_valid = 1; > frame->active_aspect = HDMI_ACTIVE_ASPECT_PICTURE; > > return 0; > -- > 1.8.3.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@xxxxxxxxxxxxxxxxxxxxx > http://lists.freedesktop.org/mailman/listinfo/dri-devel -- Ville Syrjälä Intel OTC _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
