Re: [PATCH] drm/bridge: samsung-dsim: check the return value only if necessary

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07.12.23 17:10, Dario Binacchi wrote:
> It was useless to check again the "ret" variable if the function
> register_host() was not called.
> 
> Signed-off-by: Dario Binacchi <dario.binacchi@xxxxxxxxxxxxxxxxxxxx>

Reviewed-by: Frieder Schrempf <frieder.schrempf@xxxxxxxxxx>

> ---
> 
>  drivers/gpu/drm/bridge/samsung-dsim.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c
> index be5914caa17d..98cd589e4427 100644
> --- a/drivers/gpu/drm/bridge/samsung-dsim.c
> +++ b/drivers/gpu/drm/bridge/samsung-dsim.c
> @@ -2020,11 +2020,11 @@ int samsung_dsim_probe(struct platform_device *pdev)
>  	else
>  		dsi->bridge.timings = &samsung_dsim_bridge_timings_de_high;
>  
> -	if (dsi->plat_data->host_ops && dsi->plat_data->host_ops->register_host)
> +	if (dsi->plat_data->host_ops && dsi->plat_data->host_ops->register_host) {
>  		ret = dsi->plat_data->host_ops->register_host(dsi);
> -
> -	if (ret)
> -		goto err_disable_runtime;
> +		if (ret)
> +			goto err_disable_runtime;
> +	}
>  
>  	return 0;
>  



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux