Hi, On Mon, Nov 27, 2023 at 2:15 AM Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> wrote: > > It's the ti_sn65dsi86.pwm auxiliary driver that creates the pwmchip, so > let the auxiliary device be the parent of the pwm device. > > Note that getting a reference to the ti-sn65dsi86's pwm using pwm_get() > isn't affected by this change as ti_sn65dsi86_add_aux_device() sets the > auxiliary device's of_node to that of the main device. > > Also change PM runtime tracking and diagnostic messages to use that one. > As the PM runtime functions also handle parent devices this should work > fine, too. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> > --- > Hello, > > this patch has an (easy to resolve) conflict with a patch I sent earlier > "drm/bridge: ti-sn65dsi86: Simplify using pm_runtime_resume_and_get()" > (https://lore.kernel.org/dri-devel/20231123175425.496956-2-u.kleine-koenig@xxxxxxxxxxxxxx). > I was unsure if I should base this new patch on that older one. > > While I think the patch is fine, I'd have a better feeling about it if > someone could give feedback that the PWM still works as intended with > this change. > > Best regards > Uwe > > drivers/gpu/drm/bridge/ti-sn65dsi86.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) This looks right to me. Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx> For now, I'll wait for Bjorn (or someone else who uses this PWM) to give a Tested-by before applying. -Doug
