> -----Original Message----- > From: Sachin Kamat [mailto:sachin.kamat@xxxxxxxxxx] > Sent: Friday, July 26, 2013 11:51 AM > To: Inki Dae > Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx; jy0922.shim@xxxxxxxxxxx; > patches@xxxxxxxxxx > Subject: Re: [PATCH 1/1] drm/exynos: Remove module.h header inclusion > > On 26 July 2013 07:00, Inki Dae <inki.dae@xxxxxxxxxxx> wrote: > > > > > >> -----Original Message----- > >> From: Sachin Kamat [mailto:sachin.kamat@xxxxxxxxxx] > >> Sent: Wednesday, July 24, 2013 1:43 PM > >> To: dri-devel@xxxxxxxxxxxxxxxxxxxxx > >> Cc: inki.dae@xxxxxxxxxxx; jy0922.shim@xxxxxxxxxxx; > > sachin.kamat@xxxxxxxxxx; > >> patches@xxxxxxxxxx > >> Subject: [PATCH 1/1] drm/exynos: Remove module.h header inclusion > >> > >> Since Exynos DRM drivers do not support module build, > >> remove module.h header file inclusion from files that do > >> not have any users. > > > > Not true, and supported. Actually, we are using Exynos drm driver as a > > module on our target, and that works fine. Seem like your > misunderstanding > > to my previous patch, fix module build error. > > May be my description was not clear. However the header files are > still not required as these files do not access anything provided in > module.h (after removal of MODULE_DEVICE_TABLE). > Right, please repost it with correct description. Thanks, Inki Dae > > -- > With warm regards, > Sachin _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel