This was meant as response to: Subject: [drm-intel:drm-intel-nightly 154/166] include/drm/drm_mm.h:67:2: error: unknown type name 'spinlock_t' Message-ID: <51f14693.g5HGdcuw2v3m8FOd%fengguang.wu@xxxxxxxxx> In case it didn't link to it correctly. Somehow this bug doesn't occur here on my machine, hmm. But I think fixing drm_mm.h is better than changing the include-order in drm_vma_manager.h, so this is what I did. On Thu, Jul 25, 2013 at 6:02 PM, David Herrmann <dh.herrmann@xxxxxxxxx> wrote: > We need BUG_ON(), spinlock_t and standard kernel data-types so include the > right headers. > > Signed-off-by: David Herrmann <dh.herrmann@xxxxxxxxx> > --- > include/drm/drm_mm.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/include/drm/drm_mm.h b/include/drm/drm_mm.h > index a30c9aa..d3f0aa1 100644 > --- a/include/drm/drm_mm.h > +++ b/include/drm/drm_mm.h > @@ -36,7 +36,10 @@ > /* > * Generic range manager structs > */ > +#include <linux/bug.h> > +#include <linux/kernel.h> > #include <linux/list.h> > +#include <linux/spinlock.h> > #ifdef CONFIG_DEBUG_FS > #include <linux/seq_file.h> > #endif > -- > 1.8.3.3 > _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
