On Wed, 2023-11-01 at 05:29 +1000, Dave Airlie wrote: > > > > static const struct nv_gsp_registry_entries r535_registry_entries[] = { > > { "RMSecBusResetEnable", 1 }, > > { "RMForcePcieConfigSave", 1 }, > > }; > > > > #define NV_GSP_REG_NUM_ENTRIES ARRAY_SIZE(r535_registry_entries) > > Good plan. I'll change that now. BTW, I looked into these two options. Basically, these options enable "secondary bus reset", although I'm not exactly sure what that means. It does enable saving of PCI config registers, so perhaps it preserves those registers for Nouveau when GSP-RM does a PCI reset. Also, like I mentioned on IRC earlier, I've got a bunch of patches that provide mroe robust registry control, including setting options from the command-line. I'll post those upstream once the dust has settled.