On Mon, Sep 25, 2023 at 05:07:45PM +0200, Jernej Škrabec wrote: > Dne ponedeljek, 25. september 2023 ob 09:47:15 CEST je Maxime Ripard napisal(a): > > On Sun, Sep 24, 2023 at 09:26:02PM +0200, Jernej Skrabec wrote: > > > There is no reason to register two drivers in same place. Using macro > > > lowers amount of boilerplate code. > > > > There's one actually: you can't have several module_init functions in > > the some module, and both files are compiled into the same module. > > Yeah, I figured as much. However, I think code clean up is good enough reason > to add hidden option in Kconfig and extra entry in Makefile (in v2). > > Do you agree? Yeah, I don't know. Adding more modules makes it more difficult to handle (especially autoloading) without a clear argument why. Module_init is simple enough as it is currently, maybe we should just add a comment to make it clearer? Maxime
Attachment:
signature.asc
Description: PGP signature