Hi
On Tue, Jul 16, 2013 at 9:12 AM, Daniel Vetter <daniel.vetter@xxxxxxxx> wrote:
> No one outside of drm should use this, the official interfaces are
> drm_gem_handle_create and drm_gem_handle_delete. The handle refcounting
> is purely an implementation detail of gem.
Yepp. Maybe we could even remove them as handle_reference() is only
called by handle_create().
Anyway:
Reviewed-by: David Herrmann <dh.herrmann@xxxxxxxxx>
Cheers
David
> Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxx>
> ---
> drivers/gpu/drm/drm_gem.c | 2 +-
> include/drm/drmP.h | 1 -
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c
> index 14c70b5..3b5305c 100644
> --- a/drivers/gpu/drm/drm_gem.c
> +++ b/drivers/gpu/drm/drm_gem.c
> @@ -240,7 +240,7 @@ static void drm_gem_object_handle_free(struct drm_gem_object *obj)
> }
> }
>
> -void
> +static void
> drm_gem_object_handle_unreference_unlocked(struct drm_gem_object *obj)
> {
> if (WARN_ON(obj->handle_count == 0))
> diff --git a/include/drm/drmP.h b/include/drm/drmP.h
> index 25da8e0..1da1ca2 100644
> --- a/include/drm/drmP.h
> +++ b/include/drm/drmP.h
> @@ -1670,7 +1670,6 @@ int drm_gem_handle_create(struct drm_file *file_priv,
> u32 *handlep);
> int drm_gem_handle_delete(struct drm_file *filp, u32 handle);
>
> -void drm_gem_object_handle_unreference_unlocked(struct drm_gem_object *obj);
>
> void drm_gem_free_mmap_offset(struct drm_gem_object *obj);
> int drm_gem_create_mmap_offset(struct drm_gem_object *obj);
> --
> 1.8.3.2
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@xxxxxxxxxxxxxxxxxxxxx
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel
