Hi Thomas, On Tue, Sep 12, 2023 at 5:32 PM Thomas Zimmermann <tzimmermann@xxxxxxx> wrote: > Rename the fbdev mmap helper fb_pgprotect() to pgprot_framebuffer( > The helper sets VMA page-access flags for framebuffers in device I/O > memory. > > Also clean up the helper's parameters and return value. Instead of > the VMA instance, pass the individial parameters separately: existing > page-access flags, the VMAs start and end addresses and the offset > in the underlying device memory rsp file. Return the new page-access > flags. These changes align pgprot_framebuffer() with other pgprot_() > functions. > > v4: > * fix commit message (Christophe) > v3: > * rename fb_pgprotect() to pgprot_framebuffer() (Arnd) > > Signed-off-by: Thomas Zimmermann <tzimmermann@xxxxxxx> Thanks for your patch! > arch/m68k/include/asm/fb.h | 19 ++++++++++--------- Looks like you forgot to apply my Acked-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> given on v1. I didn't notice before, as I never received v2 and v3 due to the gmail/vger email issues. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds