Hello,
When: 2013-07-10_3@10-36-22 -0700
Who: Andy Lutomirski
What:
> On Wed, Jul 10, 2013 at 10:07 AM, Torsten Kaiser
> <just.for.lkml@xxxxxxxxxxxxxx> wrote:
> > Commit 63e28a7a5ffce59b645ca9cbcc01e1e8be56bd75, "uvesafb: Clean up
> > MTRR code" contains the following change:
> >
> > @@ -1930,6 +1891,9 @@ static int uvesafb_setup(char *options)
> > }
> > }
> >
> > + if (mtrr != 3 && mtrr != 1)
> > + pr_warn("uvesafb: mtrr should be set to 0 or 3; %d is
> > unsupported", mtrr);
> > +
> > return 0;
> > }
> > #endif /* !MODULE */
> >
> > Shouldn't this be && mtrr != 0?
>
> Indeed, and Sylvain Hitier (cc'd) sent a patch (off-list) that must
> have gotten lost somewhere.
RIP patch born on 2013-06-08_6@23-02-26 +0200 ...
May your soul be happy, because here is a clone of you who will hopefully
fulfill your quest:
Fixup for commit "uvesafb: Clean up MTRR code"
(63e28a7a5ffce59b645ca9cbcc01e1e8be56bd75)
Signed-off-by: Sylvain "ythier" Hitier <sylvain.hitier@xxxxxxxxx>
Acked-by: Andy Lutomirski <luto@xxxxxxxxxxxxxx>
Also-spotted-by: Torsten Kaiser <just.for.lkml@xxxxxxxxxxxxxx>
---
drivers/video/uvesafb.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/video/uvesafb.c b/drivers/video/uvesafb.c
index 296279b..2121fc3 100644
--- a/drivers/video/uvesafb.c
+++ b/drivers/video/uvesafb.c
@@ -1891,7 +1891,7 @@ static int uvesafb_setup(char *options)
}
}
- if (mtrr != 3 && mtrr != 1)
+ if (mtrr != 3 && mtrr != 0)
pr_warn("uvesafb: mtrr should be set to 0 or 3; %d is unsupported", mtrr);
return 0;
--
Regards,
Sylvain "ythier" Hitier
--
Business is about being busy, not being rich...
Lived 777 days in a Debian package => http://en.wikipedia.org/wiki/Apt,_Vaucluse
There's THE room for ideals in this mechanical place!
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel
