Re: [PATCH 0/7] drm/msm/dp: Simplify DPCD related code with helpers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 29/08/2023 21:47, Stephen Boyd wrote:
This driver open-codes a few of the DPCD register reads when it can be
simplified by using the helpers instead. This series reworks the MSM DP
driver to use the DPCD helpers and removes some dead code along the way.
There's the potential for even more code reduction around the test
registers, but I haven't tried to do that yet.

For the whole series:

Tested-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>

Using drm_dp_get_phy_test_pattern() / drm_dp_set_phy_test_pattern() would be definitely a benefit, especially since the latter one has support for DP >= 1.2, while msm DP code doesn't.


Stephen Boyd (7):
   drm/msm/dp: Replace open-coded drm_dp_read_dpcd_caps()
   drm/msm/dp: Use drm_dp_read_sink_count() helper
   drm/msm/dp: Remove dead code related to downstream cap info
   drm/msm/dp: Remove aux_cfg_update_done and related code
   drm/msm/dp: Simplify with drm_dp_{max_link_rate,max_lane_count}()
   drm/msm/dp: Inline dp_link_parse_sink_count()
   drm/msm/dp: Remove dp_display_is_ds_bridge()

Cc: Vinod Polimera <quic_vpolimer@xxxxxxxxxxx>
Cc: Kuogee Hsieh <quic_khsieh@xxxxxxxxxxx>

  drivers/gpu/drm/msm/dp/dp_display.c |   9 +--
  drivers/gpu/drm/msm/dp/dp_link.c    |  38 +---------
  drivers/gpu/drm/msm/dp/dp_panel.c   | 105 +++++-----------------------
  drivers/gpu/drm/msm/dp/dp_panel.h   |  10 +--
  4 files changed, 22 insertions(+), 140 deletions(-)


base-commit: 2dde18cd1d8fac735875f2e4987f11817cc0bc2c

--
With best wishes
Dmitry




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux