Re: [PATCH v6 3/4] drm/bridge: Drop CONFIG_OF conditionals around of_node pointers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Aug 31, 2023 at 09:09:37AM +0100, Biju Das wrote:
> Having conditional around the of_node pointers turns out to make driver
> code use ugly #ifdef and #if blocks. So drop the conditionals.

...

>  	anx78xx->bridge.of_node = client->dev.of_node;

>  	panel_bridge->bridge.of_node = panel->dev->of_node;

>  	hdmi->bridge.of_node = pdev->dev.of_node;

>  	dsi->bridge.of_node = pdev->dev.of_node;

Yeah, I would really switch all of these to

	bridge->fwnode = dev_fwnode(...);

But it's a suggestion for a separate change that I think can happen
sooner than later.

-- 
With Best Regards,
Andy Shevchenko





[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux