On Thu, 31 Aug 2023 at 01:50, Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx> wrote: > > Since CDM block support has now been added for writeback blocks > add NV12 in the list of supported WB formats. > > Signed-off-by: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx> > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c > index 713dfc079718..978330c6678e 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c > @@ -244,6 +244,7 @@ static const uint32_t wb2_formats[] = { > DRM_FORMAT_BGRA4444, > DRM_FORMAT_BGRX4444, > DRM_FORMAT_XBGR4444, > + DRM_FORMAT_NV12, > }; No. This way the driver would announce availability of NV12 even on chipsets where NV12 is not supported for the writeback. Please define separate formats array. BTW: does HW only support NV12 for the writeback? What about YV12 or e.g. NV21? > > /************************************************************* > -- > 2.40.1 > -- With best wishes Dmitry