Hi Daniel, On Thu, Aug 24, 2023 at 5:12 PM Daniel Stone <daniel@xxxxxxxxxxxxx> wrote: > On Thu, 24 Aug 2023 at 16:09, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > > struct drm_client_dev *client = buffer->client; > > - struct drm_mode_fb_cmd fb_req = { }; > > - const struct drm_format_info *info; > > + struct drm_mode_fb_cmd2 fb_req = { }; > > int ret; > > > > - info = drm_format_info(format); > > - fb_req.bpp = drm_format_info_bpp(info, 0); > > - fb_req.depth = info->depth; > > fb_req.width = width; > > fb_req.height = height; > > - fb_req.handle = handle; > > - fb_req.pitch = buffer->pitch; > > + fb_req.pixel_format = format; > > + fb_req.handles[0] = handle; > > + fb_req.pitches[0] = buffer->pitch; > > > > - ret = drm_mode_addfb(client->dev, &fb_req, client->file); > > + ret = drm_mode_addfb2(client->dev, &fb_req, client->file); > > if (ret) > > return ret; > > This should explicitly set the LINEAR modifier (and the modifier flag) > if the driver supports modifiers. Thanks for your comment! I have no idea how to do that, and I do not know what the impact would be. All I know is that the current implementation of drm_client_buffer_addfb() does not do that, so changing that in this patch would mean that this would no longer be a trivial conversion. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds