On 8/11/23 13:18, Yue Haibing wrote:
> Commit dc5698e80cf7 ("Add virtio gpu driver.") declared but never
> implemented virtio_gpu_attach_status_page()/virtio_gpu_detach_status_page()
> Also commit 62fb7a5e1096 ("virtio-gpu: add 3d/virgl support")
> declared but never implemented virtio_gpu_fence_ack() and
> virtio_gpu_dequeue_fence_func().
> Commit c84adb304c10 ("drm/virtio: Support virtgpu exported resources")
> declared but never implemented virtgpu_gem_prime_get_uuid().
>
> Signed-off-by: Yue Haibing <yuehaibing@xxxxxxxxxx>
> ---
> drivers/gpu/drm/virtio/virtgpu_drv.h | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/virtio/virtgpu_drv.h b/drivers/gpu/drm/virtio/virtgpu_drv.h
> index 4126c384286b..8513b671f871 100644
> --- a/drivers/gpu/drm/virtio/virtgpu_drv.h
> +++ b/drivers/gpu/drm/virtio/virtgpu_drv.h
> @@ -344,8 +344,6 @@ void virtio_gpu_object_attach(struct virtio_gpu_device *vgdev,
> struct virtio_gpu_object *obj,
> struct virtio_gpu_mem_entry *ents,
> unsigned int nents);
> -int virtio_gpu_attach_status_page(struct virtio_gpu_device *vgdev);
> -int virtio_gpu_detach_status_page(struct virtio_gpu_device *vgdev);
> void virtio_gpu_cursor_ping(struct virtio_gpu_device *vgdev,
> struct virtio_gpu_output *output);
> int virtio_gpu_cmd_get_display_info(struct virtio_gpu_device *vgdev);
> @@ -394,11 +392,8 @@ virtio_gpu_cmd_resource_create_3d(struct virtio_gpu_device *vgdev,
> struct virtio_gpu_fence *fence);
> void virtio_gpu_ctrl_ack(struct virtqueue *vq);
> void virtio_gpu_cursor_ack(struct virtqueue *vq);
> -void virtio_gpu_fence_ack(struct virtqueue *vq);
> void virtio_gpu_dequeue_ctrl_func(struct work_struct *work);
> void virtio_gpu_dequeue_cursor_func(struct work_struct *work);
> -void virtio_gpu_dequeue_fence_func(struct work_struct *work);
> -
> void virtio_gpu_notify(struct virtio_gpu_device *vgdev);
>
> int
> @@ -465,8 +460,6 @@ struct dma_buf *virtgpu_gem_prime_export(struct drm_gem_object *obj,
> int flags);
> struct drm_gem_object *virtgpu_gem_prime_import(struct drm_device *dev,
> struct dma_buf *buf);
> -int virtgpu_gem_prime_get_uuid(struct drm_gem_object *obj,
> - uuid_t *uuid);
> struct drm_gem_object *virtgpu_gem_prime_import_sg_table(
> struct drm_device *dev, struct dma_buf_attachment *attach,
> struct sg_table *sgt);
Reviewed-by: Dmitry Osipenko <dmitry.osipenko@xxxxxxxxxxxxx>
--
Best regards,
Dmitry
