On 7/9/23 17:08, Sam Ravnborg wrote:
Hi Marek.
Hi,
On Sun, Jul 09, 2023 at 03:52:31PM +0200, Marek Vasut wrote:The unprepared_time has to be initialized during probe to probe time ktime, otherwise panel_simple_resume() panel_simple_wait() call may wait too short time, or no time at all, which would violate the panel timing specification. Initializing the unprepared_time() to probe time ktime assures the delay is at least what the panel requires from the time kernel started. The unprepared_time is then updated every time the panel is suspended in panel_simple_suspend() too. Fixes: e5e30dfcf3db ("drm: panel: simple: Defer unprepare delay till next prepare to shorten it") Signed-off-by: Marek Vasut <marex@xxxxxxx>Looks OK, Reviewed-by: Sam Ravnborg <sam@xxxxxxxxxxxx> It looks like prepared_time is not used anymore. Could you dig a little into this while you are in the waiting area.
Good catch, seems that has been replaced by RPM so whatever is left is just a remnant and should be dropped . I can prepare a patch, but let's see if Douglas has any further comment on this.
